Add vanilla js for add a collection element #15455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oipnet
changed the title
javiereguiluz
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
I like this a lot. Thanks!
I just wonder if we should remove the jQuery example entirely and replace it by this. Let's ask @weaverryan what he thinks. Thanks!
|
@javiereguiluz If we remove the jQuery exemple we should do same for the delete. |
|
Arnaud, thanks a lot for this improvement. What a great first contribution to Symfony Docs! Congrats 🎉 |
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Nov 8, 2021
Looks like this was just forgotten at symfony#15455 The other text I deleted merely repeated what has already been said above: > Now let the users add as many tag forms as they need directly in the browser.
wouterj
added a commit
that referenced
this pull request
Jan 16, 2022
This PR was squashed before being merged into the 5.3 branch. Discussion ---------- Removing outdated jQuery note Looks like this was just forgotten at #15455 The other text I deleted merely repeated what has already been said above: > Now let the users add as many tag forms as they need directly in the browser. Commits ------- 874f2fd Minor changes f69eb01 Removing outdated jQuery note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose an alternative without jQuery library